griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #127022: PLY export does not properly clamp vertex colors

Browse Source 
PLY always exports vertex colors as bytes currently, but the input
values were not properly clamped to 0..1 range.
This commit is contained in:
Aras Pranckevicius
2024-09-02 20:28:06 +03:00
parent 7d95fed911
commit c4a67ec3c7
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/io/ply/exporter/ply_export_data.cc
View File

@@ -10,6 +10,8 @@
#include "ply_data.hh"
#include "ply_file_buffer.hh"
#include "BLI_math_vector.hh"
namespace blender::io::ply {
void write_vertices(FileBuffer &buffer, const PlyData &ply_data)
@@ -24,10 +26,9 @@ void write_vertices(FileBuffer &buffer, const PlyData &ply_data)
}
if (!ply_data.vertex_colors.is_empty()) {
buffer.write_vertex_color(uchar(ply_data.vertex_colors[i].x * 255),
uchar(ply_data.vertex_colors[i].y * 255),
uchar(ply_data.vertex_colors[i].z * 255),
uchar(ply_data.vertex_colors[i].w * 255));
/* PLY colors currently are exported as bytes, make sure inputs are clamped. */
float4 color = math::clamp(ply_data.vertex_colors[i], 0.0f, 1.0f) * 255.0f;
buffer.write_vertex_color(uchar(color.x), uchar(color.y), uchar(color.z), uchar(color.w));
}
if (!ply_data.uv_coordinates.is_empty()) {