griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #141626: Refcount error when (un)assigning custom bone shapes

Browse Source 
Fix the ID user count when changing `posebone.custom_shape`.

The code uses `reinterpret_cast<ID *>(pchan->custom)` instead of
`&pchan->custom->id`, as the former is `nullptr`-safe.

Pull Request: https://projects.blender.org/blender/blender/pulls/141726
This commit is contained in:
Sybren A. Stüvel
2025-07-10 17:01:25 +02:00
parent 58a81f5c3a
commit c8dcbc32c4
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/makesrna/intern/rna_pose.cc
View File

@@ -645,6 +645,7 @@ void rna_Pose_custom_shape_set(PointerRNA *ptr, PointerRNA value, struct ReportL
Object *custom_shape = static_cast<Object *>(value.data);
if (!custom_shape) {
id_us_min(reinterpret_cast<ID *>(pchan->custom));
pchan->custom = nullptr;
return;
}
@@ -657,7 +658,9 @@ void rna_Pose_custom_shape_set(PointerRNA *ptr, PointerRNA value, struct ReportL
return;
}
id_us_min(reinterpret_cast<ID *>(pchan->custom));
pchan->custom = custom_shape;
id_us_plus(reinterpret_cast<ID *>(pchan->custom));
}
bool rna_Pose_custom_shape_object_poll(PointerRNA * /*ptr*/, PointerRNA value)