griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix T103936: Regression: Track To constraint broken

Browse Source 
Caused by 6769acbbba.

Some of the matrix variants are rather obscure from the
semantic: they don't really fully initialize the output:
as in, they only write to an upper-left 3x3 block.

A quick solution to fix the very commonly used constraint.
It feels that it is possible to minimize about of copy
operations.
This commit is contained in:
Sergey Sharybin
2023-01-17 17:08:30 +01:00
parent 0e89d24318
commit d411de96f7
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/blenlib/intern/math_matrix.c
View File

@@ -382,6 +382,12 @@ void mul_m4_m4m3(float R[4][4], const float A[4][4], const float B[3][3])
{
if (R == A) {
float T[4][4];
/* The mul_m4_m4m3 only writes to the upper-left 3x3 block, so make it so the rest of the
* matrix is copied from the input to the output.
*
* TODO(sergey): It does sound a bit redundant from the number of copy operations, so there is
* a potential for optimization. */
copy_m4_m4(T, A);
mul_m4_m4m3(T, A, B);
copy_m4_m4(R, T);
return;
@@ -450,6 +456,12 @@ void mul_m4_m3m4(float R[4][4], const float A[3][3], const float B[4][4])
{
if (R == B) {
float T[4][4];
/* The mul_m4_m4m3 only writes to the upper-left 3x3 block, so make it so the rest of the
* matrix is copied from the input to the output.
*
* TODO(sergey): It does sound a bit redundant from the number of copy operations, so there is
* a potential for optimization. */
copy_m4_m4(T, B);
mul_m4_m3m4(T, A, B);
copy_m4_m4(R, T);
return;