griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #147709: Use correct property for bone selection in Python

Browse Source 
Replace all calls to `pose_bone.bone.select` with
`pose_bone.select` since that is where the property lives now

Pull Request: https://projects.blender.org/blender/blender/pulls/147725
This commit is contained in:
Christoph Lendenfeld
2025-10-09 16:52:06 +02:00
committed by Christoph Lendenfeld
parent 5a8d2b6624
commit d68680ed61
4 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/addons_core/pose_library/pose_usage.py
View File

@@ -76,7 +76,7 @@ def select_bones(arm_object: Object, action: Action, *, select: bool, flipped: b
except KeyError:
continue
pose_bone.bone.select = select
pose_bone.select = select
if __name__ == '__main__':

20
scripts/addons_core/rigify/rig_ui_template.py
View File

@@ -596,10 +596,10 @@ def rotPoleToggle(rig, limb_type, controls, ik_ctrl, fk_ctrl, parent, pole):
if limb_type == 'arm':
func1 = arm_fk2ik
func2 = arm_ik2fk
rig.pose.bones[controls[0]].bone.select = not new_pole_vector_value
rig.pose.bones[controls[4]].bone.select = not new_pole_vector_value
rig.pose.bones[parent].bone.select = not new_pole_vector_value
rig.pose.bones[pole].bone.select = new_pole_vector_value
rig.pose.bones[controls[0]].select = not new_pole_vector_value
rig.pose.bones[controls[4]].select = not new_pole_vector_value
rig.pose.bones[parent].select = not new_pole_vector_value
rig.pose.bones[pole].select = new_pole_vector_value
kwargs1 = {'uarm_fk': controls[1], 'farm_fk': controls[2], 'hand_fk': controls[3],
'uarm_ik': controls[0], 'farm_ik': ik_ctrl[1],
@@ -610,11 +610,11 @@ def rotPoleToggle(rig, limb_type, controls, ik_ctrl, fk_ctrl, parent, pole):
else:
func1 = leg_fk2ik
func2 = leg_ik2fk
rig.pose.bones[controls[0]].bone.select = not new_pole_vector_value
rig.pose.bones[controls[6]].bone.select = not new_pole_vector_value
rig.pose.bones[controls[5]].bone.select = not new_pole_vector_value
rig.pose.bones[parent].bone.select = not new_pole_vector_value
rig.pose.bones[pole].bone.select = new_pole_vector_value
rig.pose.bones[controls[0]].select = not new_pole_vector_value
rig.pose.bones[controls[6]].select = not new_pole_vector_value
rig.pose.bones[controls[5]].select = not new_pole_vector_value
rig.pose.bones[parent].select = not new_pole_vector_value
rig.pose.bones[pole].select = new_pole_vector_value
kwargs1 = {'thigh_fk': controls[1], 'shin_fk': controls[2], 'foot_fk': controls[3],
'mfoot_fk': controls[7], 'thigh_ik': controls[0], 'shin_ik': ik_ctrl[1],
@@ -787,7 +787,7 @@ class Rigify_Rot2PoleSwitch(bpy.types.Operator):
if self.bone_name:
bpy.ops.pose.select_all(action='DESELECT')
rig.pose.bones[self.bone_name].bone.select = True
rig.pose.bones[self.bone_name].select = True
rotPoleToggle(rig, self.limb_type, self.controls, self.ik_ctrl, self.fk_ctrl,
self.parent, self.pole)

50
scripts/addons_core/rigify/ui.py
View File

@@ -1353,10 +1353,10 @@ def fk_to_ik(rig: ArmatureObject, window='ALL'):
# fk_ctrl = names['fk_ctrl']
parent = names['parent']
pole = names['pole']
rig.pose.bones[controls[0]].bone.select = True
rig.pose.bones[controls[4]].bone.select = True
rig.pose.bones[pole].bone.select = True
rig.pose.bones[parent].bone.select = True
rig.pose.bones[controls[0]].select = True
rig.pose.bones[controls[4]].select = True
rig.pose.bones[pole].select = True
rig.pose.bones[parent].select = True
kwargs = {'uarm_fk': controls[1], 'farm_fk': controls[2], 'hand_fk': controls[3],
'uarm_ik': controls[0], 'farm_ik': ik_ctrl[1], 'hand_ik': controls[4],
'pole': pole, 'main_parent': parent}
@@ -1369,11 +1369,11 @@ def fk_to_ik(rig: ArmatureObject, window='ALL'):
# fk_ctrl = names['fk_ctrl']
parent = names['parent']
pole = names['pole']
rig.pose.bones[controls[0]].bone.select = True
rig.pose.bones[controls[6]].bone.select = True
rig.pose.bones[controls[5]].bone.select = True
rig.pose.bones[pole].bone.select = True
rig.pose.bones[parent].bone.select = True
rig.pose.bones[controls[0]].select = True
rig.pose.bones[controls[6]].select = True
rig.pose.bones[controls[5]].select = True
rig.pose.bones[pole].select = True
rig.pose.bones[parent].select = True
# noinspection SpellCheckingInspection
kwargs = {'thigh_fk': controls[1], 'shin_fk': controls[2], 'foot_fk': controls[3],
'mfoot_fk': controls[7], 'thigh_ik': controls[0], 'shin_ik': ik_ctrl[1],
@@ -1432,9 +1432,9 @@ def ik_to_fk(rig: ArmatureObject, window='ALL'):
# fk_ctrl = names['fk_ctrl']
parent = names['parent']
pole = names['pole']
rig.pose.bones[controls[1]].bone.select = True
rig.pose.bones[controls[2]].bone.select = True
rig.pose.bones[controls[3]].bone.select = True
rig.pose.bones[controls[1]].select = True
rig.pose.bones[controls[2]].select = True
rig.pose.bones[controls[3]].select = True
kwargs = {'uarm_fk': controls[1], 'farm_fk': controls[2], 'hand_fk': controls[3],
'uarm_ik': controls[0], 'farm_ik': ik_ctrl[1],
'hand_ik': controls[4]}
@@ -1447,9 +1447,9 @@ def ik_to_fk(rig: ArmatureObject, window='ALL'):
# fk_ctrl = names['fk_ctrl']
parent = names['parent']
pole = names['pole']
rig.pose.bones[controls[1]].bone.select = True
rig.pose.bones[controls[2]].bone.select = True
rig.pose.bones[controls[3]].bone.select = True
rig.pose.bones[controls[1]].select = True
rig.pose.bones[controls[2]].select = True
rig.pose.bones[controls[3]].select = True
# noinspection SpellCheckingInspection
kwargs = {'thigh_fk': controls[1], 'shin_fk': controls[2], 'foot_fk': controls[3],
'mfoot_fk': controls[7], 'thigh_ik': controls[0], 'shin_ik': ik_ctrl[1],
@@ -1550,10 +1550,10 @@ def rot_pole_toggle(rig: ArmatureObject, window='ALL', value=False, toggle=False
# fk_ctrl = names['fk_ctrl']
parent = names['parent']
pole = names['pole']
rig.pose.bones[controls[0]].bone.select = not new_pole_vector_value
rig.pose.bones[controls[4]].bone.select = not new_pole_vector_value
rig.pose.bones[parent].bone.select = not new_pole_vector_value
rig.pose.bones[pole].bone.select = new_pole_vector_value
rig.pose.bones[controls[0]].select = not new_pole_vector_value
rig.pose.bones[controls[4]].select = not new_pole_vector_value
rig.pose.bones[parent].select = not new_pole_vector_value
rig.pose.bones[pole].select = new_pole_vector_value
kwargs1 = {'uarm_fk': controls[1], 'farm_fk': controls[2], 'hand_fk': controls[3],
'uarm_ik': controls[0], 'farm_ik': ik_ctrl[1],
@@ -1570,11 +1570,11 @@ def rot_pole_toggle(rig: ArmatureObject, window='ALL', value=False, toggle=False
# fk_ctrl = names['fk_ctrl']
parent = names['parent']
pole = names['pole']
rig.pose.bones[controls[0]].bone.select = not new_pole_vector_value
rig.pose.bones[controls[6]].bone.select = not new_pole_vector_value
rig.pose.bones[controls[5]].bone.select = not new_pole_vector_value
rig.pose.bones[parent].bone.select = not new_pole_vector_value
rig.pose.bones[pole].bone.select = new_pole_vector_value
rig.pose.bones[controls[0]].select = not new_pole_vector_value
rig.pose.bones[controls[6]].select = not new_pole_vector_value
rig.pose.bones[controls[5]].select = not new_pole_vector_value
rig.pose.bones[parent].select = not new_pole_vector_value
rig.pose.bones[pole].select = new_pole_vector_value
# noinspection SpellCheckingInspection
kwargs1 = {'thigh_fk': controls[1], 'shin_fk': controls[2], 'foot_fk': controls[3],
@@ -1711,7 +1711,7 @@ class OBJECT_OT_Rot2Pole(bpy.types.Operator):
if self.bone_name:
bpy.ops.pose.select_all(action='DESELECT')
rig.pose.bones[self.bone_name].bone.select = True
rig.pose.bones[self.bone_name].select = True
rot_pole_toggle(rig, window=self.window, toggle=self.toggle, value=self.value, bake=self.bake)
return {'FINISHED'}

4
scripts/startup/bl_operators/bone_selection_sets.py
View File

@@ -247,7 +247,7 @@ class POSE_OT_selection_set_select(_NeedSelSetMixin, Operator):
for bone in context.visible_pose_bones:
if bone.name in sel_set.bone_ids:
bone.bone.select = True
bone.select = True
return {'FINISHED'}
@@ -264,7 +264,7 @@ class POSE_OT_selection_set_deselect(_NeedSelSetMixin, Operator):
for bone in context.selected_pose_bones:
if bone.name in act_sel_set.bone_ids:
bone.bone.select = False
bone.select = False
return {'FINISHED'}