griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

VSE: Make strip translate/grab tool round resulting position

Browse Source 
Make the preview window translate/grab too round the resulting strip positions
to integer pixels. Resulting strip will more often end up using faster
interpolation (without bilinear), and avoids "text edges are too dark"
artifacts with light text strips on light backgrounds.
The latter happens because bilinear filtering does not do full alpha
premultiplication, so a text strip pixel that is just outside the glyph ends up
being (0,0,0,0) which under bilinear filtering sneaks in a dark color into the
glyph edge.

Example images in PR.

Pull Request: https://projects.blender.org/blender/blender/pulls/121652
This commit is contained in:
Aras Pranckevicius
2024-05-10 17:46:04 +02:00
committed by Aras Pranckevicius
parent 58cf1a7c44
commit ddc423b81c
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/editors/transform/transform_convert_sequencer_image.cc
View File

@@ -232,8 +232,13 @@ static void recalcData_sequencer_image(TransInfo *t)
mul_v2_v2(translation, mirror);
translation[0] *= t->scene->r.yasp / t->scene->r.xasp;
transform->xofs = tdseq->orig_translation[0] - translation[0];
transform->yofs = tdseq->orig_translation[1] - translation[1];
/* Round resulting position to integer pixels. Resulting strip
* will more often end up using faster interpolation (without bilinear),
* and avoids "text edges are too dark" artifacts with light text strips
* on light backgrounds. The latter happens because bilinear filtering
* does not do full alpha premultiplication. */
transform->xofs = roundf(tdseq->orig_translation[0] - translation[0]);
transform->yofs = roundf(tdseq->orig_translation[1] - translation[1]);
/* Scale. */
transform->scale_x = tdseq->orig_scale[0] * fabs(len_v2(handle_x));