griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Draw: Add support for uint specialization constants

Browse Source 
When implementing film accumulation specialization constants we came
across a missing implementation for uint as specialization constant.
This is a split-off from the original patch to add support for uint.

When using it is important to compile with asserts on. uint can be casted
to int without knowning. There are assert mechanism that point you to
these cases.

Pull Request: https://projects.blender.org/blender/blender/pulls/118750
This commit is contained in:
Jeroen Bakker
2024-02-26 16:18:09 +01:00
parent bace4c9a29
commit e5b9bbe0ae
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/draw/intern/draw_command.hh
View File

@@ -303,11 +303,11 @@ struct SpecializeConstant {
/* Value of the constant or a reference to it. */
union {
int int_value;
int uint_value;
uint uint_value;
float float_value;
bool bool_value;
const int *int_ref;
const int *uint_ref;
const uint *uint_ref;
const float *float_ref;
const bool *bool_ref;
};
@@ -331,12 +331,16 @@ struct SpecializeConstant {
: shader(sh), float_value(val), location(loc), type(Type::FloatValue){};
SpecializeConstant(GPUShader *sh, int loc, const int &val)
: shader(sh), int_value(val), location(loc), type(Type::IntValue){};
SpecializeConstant(GPUShader *sh, int loc, const uint &val)
: shader(sh), uint_value(val), location(loc), type(Type::UintValue){};
SpecializeConstant(GPUShader *sh, int loc, const bool &val)
: shader(sh), bool_value(val), location(loc), type(Type::BoolValue){};
SpecializeConstant(GPUShader *sh, int loc, const float *val)
: shader(sh), float_ref(val), location(loc), type(Type::FloatReference){};
SpecializeConstant(GPUShader *sh, int loc, const int *val)
: shader(sh), int_ref(val), location(loc), type(Type::IntReference){};
SpecializeConstant(GPUShader *sh, int loc, const uint *val)
: shader(sh), uint_ref(val), location(loc), type(Type::UintReference){};
SpecializeConstant(GPUShader *sh, int loc, const bool *val)
: shader(sh), bool_ref(val), location(loc), type(Type::BoolReference){};