griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Curves: Avoid optimization to avoid storing selection for now

Browse Source 
This optimization should be restored when there is proper vizualization
for the selection attributes.
This commit is contained in:
Hans Goudey
2022-06-01 11:57:38 +02:00
parent 110c90b3cf
commit e9eae1b857
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/editors/curves/intern/curves_ops.cc
View File

@@ -848,10 +848,21 @@ static int select_all_exec(bContext *C, wmOperator *op)
for (Curves *curves_id : unique_curves) {
if (action == SEL_SELECT) {
/* The optimization to avoid storing the selection when everything is selected causes too
* many problems at the moment, since there is no proper visualization yet. Keep the code but
* disable it for now. */
#if 0
CurveComponent component;
component.replace(curves_id, GeometryOwnershipType::Editable);
component.attribute_try_delete(".selection_point_float");
component.attribute_try_delete(".selection_curve_float");
#else
CurvesGeometry &curves = CurvesGeometry::wrap(curves_id->geometry);
MutableSpan<float> selection = curves_id->selection_domain == ATTR_DOMAIN_POINT ?
curves.selection_point_float_for_write() :
curves.selection_curve_float_for_write();
selection.fill(1.0f);
#endif
}
else {
CurvesGeometry &curves = CurvesGeometry::wrap(curves_id->geometry);