griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix T93642: value used as transform offset is ignored in some modes

Browse Source 
If a transform operator is executed as modal and has a "value" set, that value works as an offset.

However few transform modes were supporting this.

Include more transform modes as supported.
This commit is contained in:
Germano Cavalcante
2021-12-08 14:20:03 -03:00
parent 6ebc581b52
commit f32b63ec58
18 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
source/blender/editors/transform/transform_mode_bbone_resize.c
View File

@@ -123,6 +123,7 @@ static void applyBoneSize(TransInfo *t, const int UNUSED(mval[2]))
float ratio = t->values[0];
copy_v3_fl(t->values_final, ratio);
add_v3_v3(t->values_final, t->values_modal_offset);
transform_snap_increment(t, t->values_final);

2
source/blender/editors/transform/transform_mode_boneenvelope.c
View File

@@ -51,7 +51,7 @@ static void applyBoneEnvelope(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
ratio = t->values[0];
ratio = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &ratio);

2
source/blender/editors/transform/transform_mode_boneroll.c
View File

@@ -52,7 +52,7 @@ static void applyBoneRoll(TransInfo *t, const int UNUSED(mval[2]))
float final;
final = t->values[0];
final = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &final);

2
source/blender/editors/transform/transform_mode_curveshrinkfatten.c
View File

@@ -51,7 +51,7 @@ static void applyCurveShrinkFatten(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
ratio = t->values[0];
ratio = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &ratio);

2
source/blender/editors/transform/transform_mode_edge_bevelweight.c
View File

@@ -96,7 +96,7 @@ static void applyBevelWeight(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
weight = t->values[0];
weight = t->values[0] + t->values_modal_offset[0];
CLAMP_MAX(weight, 1.0f);

2
source/blender/editors/transform/transform_mode_edge_crease.c
View File

@@ -97,7 +97,7 @@ static void applyCrease(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
crease = t->values[0];
crease = t->values[0] + t->values_modal_offset[0];
CLAMP_MAX(crease, 1.0f);

2
source/blender/editors/transform/transform_mode_edge_rotate_normal.c
View File

@@ -95,7 +95,7 @@ static void applyNormalRotation(TransInfo *t, const int UNUSED(mval[2]))
float axis[3];
float mat[3][3];
float angle = t->values[0];
float angle = t->values[0] + t->values_modal_offset[0];
copy_v3_v3(axis, axis_final);
transform_snap_increment(t, &angle);

2
source/blender/editors/transform/transform_mode_edge_slide.c
View File

@@ -1458,7 +1458,7 @@ static void applyEdgeSlide(TransInfo *t, const int UNUSED(mval[2]))
const bool is_clamp = !(t->flag & T_ALT_TRANSFORM);
const bool is_constrained = !(is_clamp == false || hasNumInput(&t->num));
final = t->values[0];
final = t->values[0] + t->values_modal_offset[0];
applySnapping(t, &final);
if (!validSnap(t)) {

2
source/blender/editors/transform/transform_mode_gpopacity.c
View File

@@ -53,7 +53,7 @@ static void applyGPOpacity(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
ratio = t->values[0];
ratio = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &ratio);

2
source/blender/editors/transform/transform_mode_gpshrinkfatten.c
View File

@@ -53,7 +53,7 @@ static void applyGPShrinkFatten(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
ratio = t->values[0];
ratio = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &ratio);

2
source/blender/editors/transform/transform_mode_maskshrinkfatten.c
View File

@@ -52,7 +52,7 @@ static void applyMaskShrinkFatten(TransInfo *t, const int UNUSED(mval[2]))
bool initial_feather = false;
char str[UI_MAX_DRAW_STR];
ratio = t->values[0];
ratio = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &ratio);

2
source/blender/editors/transform/transform_mode_push_pull.c
View File

@@ -124,7 +124,7 @@ static void applyPushPull(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
distance = t->values[0];
distance = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &distance);

2
source/blender/editors/transform/transform_mode_shear.c
View File

@@ -199,7 +199,7 @@ static void applyShear(TransInfo *t, const int UNUSED(mval[2]))
char str[UI_MAX_DRAW_STR];
const bool is_local_center = transdata_check_local_center(t, t->around);
value = t->values[0];
value = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &value);

2
source/blender/editors/transform/transform_mode_shrink_fatten.c
View File

@@ -110,7 +110,7 @@ static void applyShrinkFatten(TransInfo *t, const int UNUSED(mval[2]))
size_t ofs = 0;
UnitSettings *unit = &t->scene->unit;
distance = t->values[0];
distance = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &distance);

1
source/blender/editors/transform/transform_mode_skin_resize.c
View File

@@ -107,6 +107,7 @@ static void applySkinResize(TransInfo *t, const int UNUSED(mval[2]))
}
else {
copy_v3_fl(t->values_final, t->values[0]);
add_v3_v3(t->values_final, t->values_modal_offset);
transform_snap_increment(t, t->values_final);

2
source/blender/editors/transform/transform_mode_tilt.c
View File

@@ -52,7 +52,7 @@ static void applyTilt(TransInfo *t, const int UNUSED(mval[2]))
float final;
final = t->values[0];
final = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &final);

2
source/blender/editors/transform/transform_mode_tosphere.c
View File

@@ -194,7 +194,7 @@ static void applyToSphere(TransInfo *t, const int UNUSED(mval[2]))
int i;
char str[UI_MAX_DRAW_STR];
ratio = t->values[0];
ratio = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &ratio);

2
source/blender/editors/transform/transform_mode_vert_slide.c
View File

@@ -582,7 +582,7 @@ static void applyVertSlide(TransInfo *t, const int UNUSED(mval[2]))
const bool is_clamp = !(t->flag & T_ALT_TRANSFORM);
const bool is_constrained = !(is_clamp == false || hasNumInput(&t->num));
final = t->values[0];
final = t->values[0] + t->values_modal_offset[0];
applySnapping(t, &final);
if (!validSnap(t)) {