griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Geometry Nodes: Triangulate Mesh node assertion case

Browse Source 
Typo from ea875f6f32.
A range of triangles is pushed into the mask, but _last_ instead of _end_
was  used. This was found in #132333 report, but this PR does not fix a
reported issue.

Pull Request: https://projects.blender.org/blender/blender/pulls/132405
This commit is contained in:
Iliya Katueshenock
2025-01-03 01:42:39 +01:00
committed by Hans Goudey
parent 0c544974d1
commit fa8574b80b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/geometry/intern/mesh_triangulate.cc
View File

@@ -554,12 +554,13 @@ static IndexMask calc_unselected_faces(const Mesh &mesh,
memory,
[&](const IndexMaskSegment universe_segment, IndexRangesBuilder<int16_t> &builder) {
if (unique_sorted_indices::non_empty_is_range(universe_segment.base_span())) {
const IndexRange segment_range(universe_segment[0], universe_segment.size());
const IndexRange universe_as_range = unique_sorted_indices::non_empty_as_range(
universe_segment.base_span());
const IndexRange segment_range = universe_as_range.shift(universe_segment.offset());
const OffsetIndices segment_faces = src_faces.slice(segment_range);
if (segment_faces.total_size() == segment_faces.size() * 3) {
/* All faces in segment are triangles. */
builder.add_range(universe_segment.base_span().first(),
universe_segment.base_span().last());
builder.add_range(universe_as_range.start(), universe_as_range.one_after_last());
return universe_segment.offset();
}
}