griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #107648: Proportional Edit sometimes cancels GPencil keyframe transformation

Browse Source 
The selection flag (`TD_SELECTED`) of transform data is essential for
Proportional Edit. If set up incorrectly, it may result in early
cancellation.
This commit is contained in:
Germano Cavalcante
2023-05-05 18:47:20 -03:00
parent d1bfda16bb
commit fcddc1a1af
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/editors/transform/transform_convert_action.c
View File

@@ -233,7 +233,8 @@ static int GPLayerToTransData(TransData *td,
/* check for select frames on right side of current frame */
for (gpf = gpl->frames.first; gpf; gpf = gpf->next) {
if (is_prop_edit || (gpf->flag & GP_FRAME_SELECT)) {
const bool is_selected = (gpf->flag & GP_FRAME_SELECT) != 0;
if (is_prop_edit || is_selected) {
if (FrameOnMouseSide(side, (float)gpf->framenum, cfra)) {
tfd->val = (float)gpf->framenum;
tfd->sdata = &gpf->framenum;
@@ -244,6 +245,10 @@ static int GPLayerToTransData(TransData *td,
td->center[0] = td->ival;
td->center[1] = ypos;
if (is_selected) {
td->flag = TD_SELECTED;
}
/* Advance `td` now. */
td++;
tfd++;