Howard Trickey
cbcc2c22d9
Fix Bevel T64107 - width/depth value wrong for vertex only.
...
Code fix from George Vogiatzis (Gvgeo), via D4811.
Needed to initalize vert_axis.
2019-05-07 09:28:34 -04:00
Campbell Barton
909665a0d4
ClangFormat: run with ReflowComments on source/
...
Prepare for enabling ReflowComments.
2019-05-01 11:13:14 +10:00
Howard Trickey
3e780507bd
Fix T63759 Vertex Bevel works for width and depth offset types.
...
From D4719 by George Vogiatzis (Gvgeo).
2019-04-30 07:13:22 -04:00
Campbell Barton
ee192a35e8
Cleanup: comments (long lines) in bmesh
2019-04-29 22:06:26 +10:00
Campbell Barton
7d6a9b5517
Cleanup: style, use braces
...
Add braces for modules already using braces almost everywhere.
2019-04-22 19:48:17 +10:00
Campbell Barton
2fb9c8ef12
Cleanup: add missing macros to clang-format
2019-04-21 04:40:16 +10:00
Sebastian Parborg
c3a11a5671
Fix T63247: edbm_rip_invoke__edge rips unselected verts on mesh borders
...
Ripping edges would in some cases rip verts on unselected edges. This is now fixed so that we only rip verts from the actually selected edges.
Reviewed By: Brecht
Differential Revision: http://developer.blender.org/D4646
2019-04-17 12:33:33 +02:00
Campbell Barton
41d4a19865
ClangFormat: format '#if 0' code in source/
2019-04-17 08:24:14 +02:00
Campbell Barton
e12c08e8d1
ClangFormat: apply to source, most of intern
...
Apply clang format as proposed in T53211.
For details on usage and instructions for migrating branches
without conflicts, see:
https://wiki.blender.org/wiki/Tools/ClangFormat
2019-04-17 06:21:24 +02:00
Campbell Barton
58233e980e
Cleanup: avoid adjacent C-style comments
...
Causes clang-format to give different results on a second run.
2019-04-16 17:50:17 +02:00
Howard Trickey
61fa6165df
Fix T63071: Bevel inconsistent results toggling harden_normals.
...
Some iterations in bevel were over a hash table, which leads
to possibly different results run-to-run, especially when
loop_slide is enabled. Changed those iters to go over all verts
of BMesh, which leads to consistent order run-to-run.
2019-04-01 07:58:34 -04:00
Campbell Barton
8d7005d715
Cleanup: style, use braces for bmesh
2019-03-27 17:14:36 +11:00
Campbell Barton
23a76491eb
Cleanup: style, use const args where possible
2019-03-23 12:16:38 +11:00
Ish Bosamiya
da5b6ed75b
Modifiers: add minimum number of vertices to triangulate modifier.
...
This lets you only triangulate n-gons when setting the number to 5 or more.
Differential Revision: https://developer.blender.org/D4367
2019-03-22 18:11:14 +01:00
Campbell Barton
109cbdf2e1
Cleanup: use BLI_kdtree_3d prefix
...
Use prefix now there isn't only the 3d version.
2019-03-20 00:48:51 +11:00
Campbell Barton
e7fd6c8f30
Cleanup: comment blocks
2019-03-19 15:17:46 +11:00
Campbell Barton
35b78d9807
Cleanup: indentation, wrapping
...
Mostly functions wrapping args, not confirming to our style guide.
2019-03-15 09:54:30 +11:00
Campbell Barton
18e5540a48
Cleanup: remove redundant file argument
2019-03-06 11:18:17 +11:00
Howard Trickey
2b892c6c21
Fix T61988, Bevel miter on small scale.
...
Take two at fix, hopefully without unintended commits
to submodules this time.
2019-02-27 11:52:30 -05:00
Howard Trickey
4243c29463
Revert "Fix T61988: Bevel mitering on small objects."
...
This reverts commit 048088e1d2 .
Accidentally changed submodules. Will resubmit with only
intended changes later.
2019-02-27 11:42:48 -05:00
Howard Trickey
048088e1d2
Fix T61988: Bevel mitering on small objects.
...
When edges had small length (less than about .005) the angle
classification didn't work. Needed some normalization of vectors.
2019-02-27 07:51:57 -05:00
Campbell Barton
de13d0a80c
doxygen: add newline after \file
...
While \file doesn't need an argument, it can't have another doxy
command after it.
2019-02-18 08:22:12 +11:00
Howard Trickey
dd97b09fa8
Bevel: fix twist on bevel of cylinder with >= 200 sides.
...
This triggered an "almost parallel" case in setting the
offset meet points, which is OK but code needed improvement
put the meet point in a more accurate place.
This ia fix for part of the report T61214.
2019-02-15 08:32:07 -05:00
Howard Trickey
5c432cd11b
Fix T61427: Bevel crash with patch miter.
...
The adjustment phase had broken assumptions after adding miters,
and sent a null problem to eigen. Fixed code to check assumptions.
2019-02-14 17:21:50 -05:00
Campbell Barton
452df3f392
Cleanup: comments
2019-02-12 01:51:03 +11:00
Campbell Barton
ffd0fee97c
Cleanup: comment indentation & spelling
2019-02-11 10:51:25 +11:00
Howard Trickey
2f0dbdea4f
Bevel, fix crash when adjust offsets with inner arc miter.
...
Previous assumptions about boundary verts always being attached
to edges are now false.
2019-02-08 09:24:43 -05:00
Howard Trickey
29922b6ff5
Bevel: fix regression re even adjustment of offsets.
...
Mistakenly had left a debugging assignment that disabled
the offset pass. This commit re-enables it.
2019-02-08 09:02:29 -05:00
Howard Trickey
dec4f6d7ed
Bevel: better attachment points for unbeveled edges, arc miter.
2019-02-07 10:42:28 -05:00
Campbell Barton
eef4077f18
Cleanup: remove redundant doxygen \file argument
...
Move \ingroup onto same line to be more compact and
make it clear the file is in the group.
2019-02-06 15:45:22 +11:00
Campbell Barton
65ec7ec524
Cleanup: remove redundant, invalid info from headers
...
BF-admins agree to remove header information that isn't useful,
to reduce noise.
- BEGIN/END license blocks
Developers should add non license comments as separate comment blocks.
No need for separator text.
- Contributors
This is often invalid, outdated or misleading
especially when splitting files.
It's more useful to git-blame to find out who has developed the code.
See P901 for script to perform these edits.
2019-02-02 01:36:28 +11:00
Campbell Barton
293f4d88da
Cleanup: style, unused variable
2019-01-31 15:54:37 +11:00
Howard Trickey
79f76c8544
Bevel - better corner shapes for inner arc miters.
...
The subdivision method for getting corner shapes has a fullness
parameter which had been set by eye before. This change uses fullness
as found by offline search process to best match the superellipsoid
octant in the cube corner case (except cube corner case is still handled
by other code). This somewhat improves the look of cube corners with
inner arc miters, however.
2019-01-29 07:21:59 -05:00
Campbell Barton
1e4aab36c2
Cleanup: remove redundant BKE/BLI/BIF headers
2019-01-26 21:20:25 +11:00
Campbell Barton
49208a3419
Cleanup: shadow warning, style
2019-01-21 10:05:58 +11:00
Howard Trickey
b640fd829e
Add miter pattern options.
...
Will document the new options in release notes, then in manual.
Still a bit of work to do on the bulging shape that appears
on cube corners if using arc inner miters, but will do that later.
Also need to do something smarter in clamp overlap.
2019-01-18 12:54:10 -05:00
Campbell Barton
88a80fcec8
Cleanup: commas at the end of enums
...
Without this clang-format may wrap them onto a single line.
2019-01-16 00:03:03 +11:00
Campbell Barton
f91b21f85b
Cleanup: move comments above definitions
...
For clang-format not to wrap definitions.
2019-01-14 16:30:43 +11:00
Campbell Barton
91a155833e
Cleanup: comments causing bad clang-format output
2019-01-08 10:37:43 +11:00
Howard Trickey
496f6adce2
Better bevel normal hardening when some faces were smooth.
...
Harden normals causes normal splitting, which will not give the
appearance expected due to autosmooth unless some edges are sharpened,
so this change fixes that. Also bevel tool will turn on autosmooth
if not already on if hardening normals.
2019-01-06 18:12:00 -05:00
Howard Trickey
aef01c47e6
Fix T58113 Multiple problems with bevel harden normals.
...
Move the bevel hardening code all into bmesh_bevel.c.
Based on user feedback, rewrote the bevel hardening algorithm
to be more what users want.
Based on user feedback, changed the UI, removing some
not-useful options. Now hardening normals while beveling
is enabled by a simple checkbox.
Now setting face strength gives options for which faces
get their face strength set.
2019-01-03 13:39:52 -05:00
Campbell Barton
543ddbe6bf
Cleanup: warnings (clang)
2018-12-30 15:15:05 +11:00
Jacques Lucke
ae028ef206
Fix T57045: Unhandled degenerate case in bevel code
...
Reviewers: howardt
Differential Revision: https://developer.blender.org/D4104
2018-12-20 10:58:50 +01:00
Campbell Barton
d46d8e831c
Merge branch 'master' into blender2.8
2018-12-19 10:28:26 +11:00
Campbell Barton
5c3953010d
Cleanup: spelling
2018-12-19 10:18:15 +11:00
Campbell Barton
dd4c87cd04
Merge branch 'master' into blender2.8
2018-12-14 11:09:42 +11:00
Campbell Barton
6e2d9ef2db
Cleanup: naming (mean -> median) see T47811
2018-12-14 10:54:11 +11:00
Campbell Barton
49490e5cfb
Merge branch 'master' into blender2.8
2018-12-12 13:02:09 +11:00
Campbell Barton
e757c4a3be
Cleanup: use colon separator after parameter
...
Helps separate variable names from descriptive text.
Was already used in some parts of the code,
double space and dashes were used elsewhere.
2018-12-12 12:50:58 +11:00
Brecht Van Lommel
6f08124fbd
Fix assert in bevel modifier with certain geometry.
...
This happened in in the barbershop_interior.blend benchmark file, seems
duplicate hash entries are ok for this algorithm.
2018-11-14 18:21:28 +01:00