Most of these crashes happen because it is assumed that the scene will always be present even if we have an uninitialized `Editing`, which is no longer the case with #140271. - Fix crash when clicking and dragging in the scrub area by checking for valid `sequencer_scene` in `change_frame_poll` - Fix crashes when selecting menu items by disabling them in the UI until a `sequencer_scene` is present - Fix crashes running operators from the F3 menu by changing to more restrictive polls that check for `sequencer_scene` - For good measure, check before dereferencing in `channels_displayed_get`, `active_seqbase_get`, and `editing_get` Pull Request: https://projects.blender.org/blender/blender/pulls/145145
255 lines
7.2 KiB
C++
255 lines
7.2 KiB
C++
/* SPDX-FileCopyrightText: 2001-2002 NaN Holding BV. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup spseq
|
|
*/
|
|
|
|
#include "DNA_scene_types.h"
|
|
|
|
#include "BLI_listbase.h"
|
|
|
|
#include "BKE_context.hh"
|
|
#include "BKE_global.hh"
|
|
#include "BKE_report.hh"
|
|
|
|
#include "BLT_translation.hh"
|
|
|
|
#include "SEQ_proxy.hh"
|
|
#include "SEQ_relations.hh"
|
|
#include "SEQ_sequencer.hh"
|
|
|
|
#include "WM_api.hh"
|
|
#include "WM_types.hh"
|
|
|
|
#include "RNA_define.hh"
|
|
|
|
/* For menu, popup, icons, etc. */
|
|
#include "ED_screen.hh"
|
|
|
|
/* Own include. */
|
|
#include "sequencer_intern.hh"
|
|
|
|
namespace blender::ed::vse {
|
|
|
|
/* -------------------------------------------------------------------- */
|
|
/** \name Rebuild Proxy and Timecode Indices Operator
|
|
* \{ */
|
|
|
|
static void seq_proxy_build_job(const bContext *C, ReportList *reports)
|
|
{
|
|
Scene *scene = CTX_data_sequencer_scene(C);
|
|
Editing *ed = seq::editing_get(scene);
|
|
ScrArea *area = CTX_wm_area(C);
|
|
|
|
if (ed == nullptr) {
|
|
return;
|
|
}
|
|
|
|
wmJob *wm_job = seq::ED_seq_proxy_wm_job_get(C);
|
|
seq::ProxyJob *pj = seq::ED_seq_proxy_job_get(C, wm_job);
|
|
|
|
blender::Set<std::string> processed_paths;
|
|
bool selected = false; /* Check for no selected strips */
|
|
|
|
LISTBASE_FOREACH (Strip *, strip, seq::active_seqbase_get(ed)) {
|
|
if (!ELEM(strip->type, STRIP_TYPE_MOVIE, STRIP_TYPE_IMAGE) || (strip->flag & SELECT) == 0) {
|
|
continue;
|
|
}
|
|
|
|
selected = true;
|
|
if (!(strip->flag & SEQ_USE_PROXY)) {
|
|
BKE_reportf(reports, RPT_WARNING, "Proxy is not enabled for %s, skipping", strip->name);
|
|
continue;
|
|
}
|
|
if (strip->data->proxy->build_size_flags == 0) {
|
|
BKE_reportf(
|
|
reports, RPT_WARNING, "Resolution is not selected for %s, skipping", strip->name);
|
|
continue;
|
|
}
|
|
|
|
bool success = seq::proxy_rebuild_context(
|
|
pj->main, pj->depsgraph, pj->scene, strip, &processed_paths, &pj->queue, false);
|
|
|
|
if (!success && (strip->data->proxy->build_flags & SEQ_PROXY_SKIP_EXISTING) != 0) {
|
|
BKE_reportf(reports, RPT_WARNING, "Overwrite is not checked for %s, skipping", strip->name);
|
|
}
|
|
}
|
|
|
|
if (!selected) {
|
|
BKE_reportf(reports, RPT_WARNING, "Select movie or image strips");
|
|
return;
|
|
}
|
|
|
|
if (!WM_jobs_is_running(wm_job)) {
|
|
G.is_break = false;
|
|
WM_jobs_start(CTX_wm_manager(C), wm_job);
|
|
}
|
|
|
|
ED_area_tag_redraw(area);
|
|
}
|
|
|
|
static wmOperatorStatus sequencer_rebuild_proxy_invoke(bContext *C,
|
|
wmOperator *op,
|
|
const wmEvent * /*event*/)
|
|
{
|
|
seq_proxy_build_job(C, op->reports);
|
|
|
|
return OPERATOR_FINISHED;
|
|
}
|
|
|
|
static wmOperatorStatus sequencer_rebuild_proxy_exec(bContext *C, wmOperator * /*o*/)
|
|
{
|
|
Main *bmain = CTX_data_main(C);
|
|
Depsgraph *depsgraph = CTX_data_ensure_evaluated_depsgraph(C);
|
|
Scene *scene = CTX_data_sequencer_scene(C);
|
|
Editing *ed = seq::editing_get(scene);
|
|
|
|
if (ed == nullptr) {
|
|
return OPERATOR_CANCELLED;
|
|
}
|
|
|
|
blender::Set<std::string> processed_paths;
|
|
|
|
LISTBASE_FOREACH (Strip *, strip, seq::active_seqbase_get(ed)) {
|
|
if (strip->flag & SELECT) {
|
|
ListBase queue = {nullptr, nullptr};
|
|
|
|
seq::proxy_rebuild_context(bmain, depsgraph, scene, strip, &processed_paths, &queue, false);
|
|
|
|
wmJobWorkerStatus worker_status = {};
|
|
LISTBASE_FOREACH (LinkData *, link, &queue) {
|
|
seq::IndexBuildContext *context = static_cast<seq::IndexBuildContext *>(link->data);
|
|
seq::proxy_rebuild(context, &worker_status);
|
|
seq::proxy_rebuild_finish(context, false);
|
|
}
|
|
seq::relations_free_imbuf(scene, &ed->seqbase, false);
|
|
}
|
|
}
|
|
|
|
return OPERATOR_FINISHED;
|
|
}
|
|
|
|
void SEQUENCER_OT_rebuild_proxy(wmOperatorType *ot)
|
|
{
|
|
/* Identifiers. */
|
|
ot->name = "Rebuild Proxy and Timecode Indices";
|
|
ot->idname = "SEQUENCER_OT_rebuild_proxy";
|
|
ot->description = "Rebuild all selected proxies and timecode indices";
|
|
|
|
/* API callbacks. */
|
|
ot->invoke = sequencer_rebuild_proxy_invoke;
|
|
ot->exec = sequencer_rebuild_proxy_exec;
|
|
ot->poll = sequencer_edit_poll;
|
|
|
|
/* Flags. */
|
|
ot->flag = OPTYPE_REGISTER;
|
|
}
|
|
|
|
/** \} */
|
|
|
|
/* -------------------------------------------------------------------- */
|
|
/** \name Set Selected Strip Proxies Operator
|
|
* \{ */
|
|
|
|
static wmOperatorStatus sequencer_enable_proxies_invoke(bContext *C,
|
|
wmOperator *op,
|
|
const wmEvent * /*event*/)
|
|
{
|
|
return WM_operator_props_dialog_popup(
|
|
C, op, 200, IFACE_("Set Selected Strip Proxies"), IFACE_("Set"));
|
|
}
|
|
|
|
static wmOperatorStatus sequencer_enable_proxies_exec(bContext *C, wmOperator *op)
|
|
{
|
|
Scene *scene = CTX_data_sequencer_scene(C);
|
|
Editing *ed = seq::editing_get(scene);
|
|
bool proxy_25 = RNA_boolean_get(op->ptr, "proxy_25");
|
|
bool proxy_50 = RNA_boolean_get(op->ptr, "proxy_50");
|
|
bool proxy_75 = RNA_boolean_get(op->ptr, "proxy_75");
|
|
bool proxy_100 = RNA_boolean_get(op->ptr, "proxy_100");
|
|
bool overwrite = RNA_boolean_get(op->ptr, "overwrite");
|
|
bool turnon = true;
|
|
|
|
if (ed == nullptr || !(proxy_25 || proxy_50 || proxy_75 || proxy_100)) {
|
|
turnon = false;
|
|
}
|
|
|
|
LISTBASE_FOREACH (Strip *, strip, seq::active_seqbase_get(ed)) {
|
|
if (strip->flag & SELECT) {
|
|
if (ELEM(strip->type, STRIP_TYPE_MOVIE, STRIP_TYPE_IMAGE)) {
|
|
seq::proxy_set(strip, turnon);
|
|
if (strip->data->proxy == nullptr) {
|
|
continue;
|
|
}
|
|
|
|
if (proxy_25) {
|
|
strip->data->proxy->build_size_flags |= SEQ_PROXY_IMAGE_SIZE_25;
|
|
}
|
|
else {
|
|
strip->data->proxy->build_size_flags &= ~SEQ_PROXY_IMAGE_SIZE_25;
|
|
}
|
|
|
|
if (proxy_50) {
|
|
strip->data->proxy->build_size_flags |= SEQ_PROXY_IMAGE_SIZE_50;
|
|
}
|
|
else {
|
|
strip->data->proxy->build_size_flags &= ~SEQ_PROXY_IMAGE_SIZE_50;
|
|
}
|
|
|
|
if (proxy_75) {
|
|
strip->data->proxy->build_size_flags |= SEQ_PROXY_IMAGE_SIZE_75;
|
|
}
|
|
else {
|
|
strip->data->proxy->build_size_flags &= ~SEQ_PROXY_IMAGE_SIZE_75;
|
|
}
|
|
|
|
if (proxy_100) {
|
|
strip->data->proxy->build_size_flags |= SEQ_PROXY_IMAGE_SIZE_100;
|
|
}
|
|
else {
|
|
strip->data->proxy->build_size_flags &= ~SEQ_PROXY_IMAGE_SIZE_100;
|
|
}
|
|
|
|
if (!overwrite) {
|
|
strip->data->proxy->build_flags |= SEQ_PROXY_SKIP_EXISTING;
|
|
}
|
|
else {
|
|
strip->data->proxy->build_flags &= ~SEQ_PROXY_SKIP_EXISTING;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
WM_event_add_notifier(C, NC_SCENE | ND_SEQUENCER, scene);
|
|
|
|
return OPERATOR_FINISHED;
|
|
}
|
|
|
|
void SEQUENCER_OT_enable_proxies(wmOperatorType *ot)
|
|
{
|
|
/* Identifiers. */
|
|
ot->name = "Set Selected Strip Proxies";
|
|
ot->idname = "SEQUENCER_OT_enable_proxies";
|
|
ot->description = "Enable selected proxies on all selected Movie and Image strips";
|
|
|
|
/* API callbacks. */
|
|
ot->invoke = sequencer_enable_proxies_invoke;
|
|
ot->exec = sequencer_enable_proxies_exec;
|
|
ot->poll = sequencer_edit_poll;
|
|
|
|
/* Flags. */
|
|
ot->flag = OPTYPE_REGISTER;
|
|
|
|
RNA_def_boolean(ot->srna, "proxy_25", false, "25%", "");
|
|
RNA_def_boolean(ot->srna, "proxy_50", false, "50%", "");
|
|
RNA_def_boolean(ot->srna, "proxy_75", false, "75%", "");
|
|
RNA_def_boolean(ot->srna, "proxy_100", false, "100%", "");
|
|
RNA_def_boolean(ot->srna, "overwrite", false, "Overwrite", "");
|
|
}
|
|
|
|
/** \} */
|
|
|
|
} // namespace blender::ed::vse
|