97f2b01ea9
Currently the iteration over a PBVH node's vertices retrieves mutable access to the mask custom data layer. This isn't threadsafe, but it is done in the multithreaded loops over all nodes. In general, we need to be more careful and conservative about storage of non-const pointers to mesh data. Ideally we would only have one mutable reference to a resource at a time. And we should avoid doing work like looking up custom data layers more than we need to. To that end, make the pointer to the custom data layer used everywhere const, and retrieve mutable access before parallel node iteration with a specific function, and write to the mask data with that in mind. This pushes us in the direction of sharing less code per PBVH type. In my opinion that's a good thing, because we can actually optimize for each type. For example, `write_mask_data` gives a picture of how each of these hot loops could become much simpler. Pull Request: https://projects.blender.org/blender/blender/pulls/112690
Blender
Blender is the free and open source 3D creation suite. It supports the entirety of the 3D pipeline-modeling, rigging, animation, simulation, rendering, compositing, motion tracking and video editing.
Project Pages
Development
License
Blender as a whole is licensed under the GNU General Public License, Version 3. Individual files may have a different, but compatible license.
See blender.org/about/license for details.