e3a960ef2e
Turns out the sampling module was not initialized when computing lighting which resulted in undefined shadow location. In some cases even producing NaN position which would make the shadow disappear. Basically, anything returned by `sampling_rng_nD_get` was returning garbage, and on some occasion, it could be a negative number and produce NaN if passed into `sample_disk` or any `sqrt`. ASAN did not catch it because the uninitialized data load was done on the GPU. I ran the render tests and, minor difference aside, they all match. #### Follow Up: This raises the concern that we have no assertion for correctly using some modules. At the very least, we should have some mechanism to catch uninitialized buffer. Investigating this was a pain au chocolat. Pull Request: https://projects.blender.org/blender/blender/pulls/130150
Blender
Blender is the free and open source 3D creation suite. It supports the entirety of the 3D pipeline-modeling, rigging, animation, simulation, rendering, compositing, motion tracking and video editing.
Project Pages
Development
License
Blender as a whole is licensed under the GNU General Public License, Version 3. Individual files may have a different, but compatible license.
See blender.org/about/license for details.