Fix #138140: Vulkan: Disable swapchain maintenance1
There are issues with our implementation. - X11 can flip image incorrectly. - VVL complains of incorrect usage. Disabling the extension for now until it is more clear what is not correct.
This commit is contained in:
@@ -1052,6 +1052,13 @@ GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
|
||||
requireExtension(extensions_available, extensions_enabled, VK_KHR_SURFACE_EXTENSION_NAME);
|
||||
requireExtension(extensions_available, extensions_enabled, native_surface_extension_name);
|
||||
|
||||
/* TODO: VK_EXT_swapchain_maintenance1 needs to be reviewed. It has several issues including
|
||||
* - X11 doesn't use the correct swapchain offset, flipping can squash the first frames.
|
||||
* - VVL complains of incorrect usage of fences.
|
||||
*
|
||||
* For now disabling it until we have figured out what is wrong.
|
||||
*/
|
||||
#if 0
|
||||
/* Required instance extension dependency of VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME */
|
||||
if (contains_extension(extensions_available, VK_EXT_SURFACE_MAINTENANCE_1_EXTENSION_NAME) &&
|
||||
contains_extension(extensions_available, VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME))
|
||||
@@ -1063,6 +1070,7 @@ GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
|
||||
VK_KHR_GET_SURFACE_CAPABILITIES_2_EXTENSION_NAME);
|
||||
optional_device_extensions.push_back(VK_EXT_SWAPCHAIN_MAINTENANCE_1_EXTENSION_NAME);
|
||||
}
|
||||
#endif
|
||||
|
||||
required_device_extensions.push_back(VK_KHR_SWAPCHAIN_EXTENSION_NAME);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user