griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Vulkan: Use optional extension for maintenance 4

Browse Source 
Maintenance 4 is an optional extension, however it was added to required
extension when the extension is availble. This would also be checked
when adding it as an optional extension.

Detected when reviewing !127995

Pull Request: https://projects.blender.org/blender/blender/pulls/128353
This commit is contained in:
Jeroen Bakker
2024-09-30 09:29:58 +02:00
parent 6ec35c619f
commit ecaa69f9cf
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
intern/ghost/intern/GHOST_ContextVK.cc
View File

@@ -977,6 +977,7 @@ GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
*/
optional_device_extensions.push_back(VK_EXT_DYNAMIC_RENDERING_UNUSED_ATTACHMENTS_EXTENSION_NAME);
optional_device_extensions.push_back(VK_EXT_SHADER_STENCIL_EXPORT_EXTENSION_NAME);
optional_device_extensions.push_back(VK_KHR_MAINTENANCE_4_EXTENSION_NAME);
/* Enable MoltenVK required instance extensions. */
#ifdef __APPLE__
@@ -1072,10 +1073,6 @@ GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
}
vulkan_device->users++;
/* Register optional device extensions */
if (vulkan_device->has_extensions({VK_KHR_MAINTENANCE_4_EXTENSION_NAME})) {
required_device_extensions.push_back(VK_KHR_MAINTENANCE_4_EXTENSION_NAME);
}
#ifdef WITH_VULKAN_MOLTENVK
/* According to the Vulkan specs, when `VK_KHR_portability_subset` is available it should be
* enabled. See