griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #134155: Crash when searching in properties editor.

Browse Source 
Mistake in recent RNA refactor (45f231141d), not sure why I ended up
returning empty PointerRNA with non-null type when calling
`RNA_id_create_pointer` with a null ID...

In general, PointerRNA with no data ==> no type either, we are trying to
get rid of the very few exceptions in our codebase relying on a
different behavior!
This commit is contained in:
Bastien Montagne
2025-02-06 10:36:28 +01:00
parent 3c066738fe
commit 8390fdbd66
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/makesrna/intern/rna_access.cc
View File

@@ -173,14 +173,13 @@ PointerRNA RNA_main_pointer_create(Main *main)
PointerRNA RNA_id_pointer_create(ID *id)
{
PointerRNA ptr{id, &RNA_ID, id};
if (id) {
ptr.type = ID_code_to_RNA_type(GS(id->name));
PointerRNA ptr{id, ID_code_to_RNA_type(GS(id->name)), id};
rna_pointer_refine(ptr);
return ptr;
}
return ptr;
return PointerRNA_NULL;
}
PointerRNA RNA_pointer_create_discrete(ID *id, StructRNA *type, void *data)