griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix incorrect EXPECT_M4_NEAR

Browse Source 
Seems to be a copy-paste error: the first 3 columns
were only compared as float3, not as float4.

Only affected validness of regression tests which might have
missed an actual mismatch between matrices. Likely, all tests
were valid, and this change did not discover failures.
This commit is contained in:
Sergey Sharybin
2023-07-03 18:14:45 +02:00
committed by Sergey Sharybin
parent 46d47e8f9c
commit baeb314eb7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/gtests/testing/testing.h
View File

@@ -58,9 +58,9 @@ const std::string &flags_test_release_dir(); /* bin/{blender version} in the bui
#define EXPECT_M4_NEAR(a, b, eps) \
do { \
EXPECT_V3_NEAR(a[0], b[0], eps); \
EXPECT_V3_NEAR(a[1], b[1], eps); \
EXPECT_V3_NEAR(a[2], b[2], eps); \
EXPECT_V4_NEAR(a[0], b[0], eps); \
EXPECT_V4_NEAR(a[1], b[1], eps); \
EXPECT_V4_NEAR(a[2], b[2], eps); \
EXPECT_V4_NEAR(a[3], b[3], eps); \
} while (false);