griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Vulkan: Incorrect Std430 memory layout

Browse Source 
When using float2/int2/uint2 arrays the elements could be incorrectly
alligned. This wasn't noticable when using Blender as it isn't used,
However python addons and forks can use it.

Fixes an issue with UPBGE

Pull Request: https://projects.blender.org/blender/blender/pulls/139082
This commit is contained in:
Jeroen Bakker
2025-05-19 13:24:19 +02:00
parent 239eb386ff
commit d87e0ecb61
1 changed files with 1 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
source/blender/gpu/vulkan/vk_memory_layout.cc
View File

@@ -19,31 +19,8 @@ uint32_t Std430::component_mem_size(const shader::Type /*type*/)
return 4;
}
uint32_t Std430::element_alignment(const shader::Type type, const bool is_array)
uint32_t Std430::element_alignment(const shader::Type type, const bool /*is_array*/)
{
if (is_array) {
switch (type) {
case shader::Type::float_t:
case shader::Type::uint_t:
case shader::Type::int_t:
case shader::Type::bool_t:
return 4;
case shader::Type::float2_t:
case shader::Type::uint2_t:
case shader::Type::int2_t:
case shader::Type::float3_t:
case shader::Type::uint3_t:
case shader::Type::int3_t:
case shader::Type::float4_t:
case shader::Type::uint4_t:
case shader::Type::int4_t:
case shader::Type::float3x3_t:
case shader::Type::float4x4_t:
return 16;
default:
BLI_assert_msg(false, "Type not supported in dynamic structs.");
}
}
switch (type) {
case shader::Type::float_t:
case shader::Type::uint_t: