griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #120950: Graph Editor curve drawing artifacts with normalized display

Browse Source 
The drawing code in the Graph Editor reduces the points drawn by checking the pixel distance.
The calculation for the pixel distance didn't take the normalization into account though, so
in certain scenarios points would be skipped that shouldn't be skipped.

The fix is to pass the normalization factor into the pixel distance calculation.

Pull Request: https://projects.blender.org/blender/blender/pulls/121070
This commit is contained in:
Christoph Lendenfeld
2024-04-25 11:50:55 +02:00
committed by Christoph Lendenfeld
parent 3f2c4db951
commit dafcb353b8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/editors/space_graph/graph_draw.cc
View File

@@ -976,7 +976,7 @@ static void add_extrapolation_point_right(FCurve *fcu,
curve_vertices.append(vertex_position);
}
static blender::float2 calculate_pixels_per_unit(View2D *v2d)
static blender::float2 calculate_pixels_per_unit(View2D *v2d, const float unit_scale)
{
const int window_width = BLI_rcti_size_x(&v2d->mask);
const int window_height = BLI_rcti_size_y(&v2d->mask);
@@ -984,7 +984,7 @@ static blender::float2 calculate_pixels_per_unit(View2D *v2d)
const float v2d_frame_range = BLI_rctf_size_x(&v2d->cur);
const float v2d_value_range = BLI_rctf_size_y(&v2d->cur);
const blender::float2 pixels_per_unit = {window_width / v2d_frame_range,
window_height / v2d_value_range};
(window_height / v2d_value_range) * unit_scale};
return pixels_per_unit;
}
@@ -1040,7 +1040,7 @@ static void draw_fcurve_curve_keys(
curve_vertices.append(
{fcu->bezt[index_range.first()].vec[1][0], fcu->bezt[index_range.first()].vec[1][1]});
const blender::float2 pixels_per_unit = calculate_pixels_per_unit(v2d);
const float2 pixels_per_unit = calculate_pixels_per_unit(v2d, unit_scale);
const int window_width = BLI_rcti_size_x(&v2d->mask);
const float v2d_frame_range = BLI_rctf_size_x(&v2d->cur);
const float pixel_width = v2d_frame_range / window_width;